reverse words #22
reverse words #22
Conversation
| last += 1 | ||
| end | ||
| if first == last || last == my_words.length - 1 | ||
| my_words[first..last] = string_reverse(my_words[first..last]) |
There was a problem hiding this comment.
I didn't see any comments on time and space complexity. As we saw in the first few slides of https://drive.google.com/file/d/0B__DV26QHsH4bWJmS1A0QXBad1U/view?usp=sharing because of using the substring method e.g. my_words[first..last], your space complexity will be O(n).
There was a problem hiding this comment.
Can you think of a solution by updating your string_reverse method to take two additional parameters first and last along with the complete my_words and then only reversing the characters in my_words from index first to index last?
There was a problem hiding this comment.
Once you've given it some thought, take a look at the solution at https://github.com/Ada-C10/reverse_words/blob/solution/lib/reverse_words.rb
|
Nice work! See some comments inline and slack me if you have any questions. |
No description provided.